lkddi/certd
1
0
Fork 0
mirror of https://github.com/certd/certd.git synced 2026-07-02 01:17:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(monitor,cert-plugin): 移除废弃的certFile字段相关逻辑

Browse Source 
1.  给certFile字段添加废弃注释
2.  删除证书申请成功事件中传递的file参数
3.  简化updateCertByPipelineId方法参数，移除file相关入参和赋值逻辑
This commit is contained in:
xiaojunnuo
2026-07-01 01:10:08 +08:00
parent bce7d95838
commit b35e7b0702
4 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/certd-server/src/modules/auto/auto-pipeline-emitter-register.ts
+2 -2
View File
@@ -15,8 +15,8 @@ export class AutoPipelineEmitterRegister {
}
async onCertApplySuccess() {
pipelineEmitter.on(EVENT_CERT_APPLY_SUCCESS, async (event: PipelineEvent<{ cert: CertInfo; file: string }>) => {
await this.certInfoService.updateCertByPipelineId(event.pipeline.id, event.event.cert, event.event.file);
pipelineEmitter.on(EVENT_CERT_APPLY_SUCCESS, async (event: PipelineEvent<{ cert: CertInfo }>) => {
await this.certInfoService.updateCertByPipelineId(event.pipeline.id, event.event.cert);
});
}
}
packages/ui/certd-server/src/modules/monitor/entity/cert-info.ts
+1
View File
@@ -42,6 +42,7 @@ export class CertInfoEntity {
@Column({ name: "cert_info", comment: "证书详情" })
certInfo: string;
// Deprecated 废弃
@Column({ name: "cert_file", comment: "证书下载" })
certFile: string;
packages/ui/certd-server/src/modules/monitor/service/cert-info-service.ts
+1 -6
View File
@@ -12,7 +12,6 @@ export type UploadCertReq = {
fromType?: string;
userId?: number;
projectId?: number;
file?: any;
};
@Provide("CertInfoService")
@@ -158,7 +157,7 @@ export class CertInfoService extends BaseService<CertInfoEntity> {
};
}
async updateCertByPipelineId(pipelineId: number, cert: CertInfo, file?: string, fromType = "pipeline") {
async updateCertByPipelineId(pipelineId: number, cert: CertInfo, fromType = "pipeline") {
const found = await this.repository.findOne({
where: {
pipelineId,
@@ -168,7 +167,6 @@ export class CertInfoService extends BaseService<CertInfoEntity> {
id: found?.id,
certReader: new CertReader(cert),
fromType,
file,
});
return bean;
}
@@ -194,9 +192,6 @@ export class CertInfoService extends BaseService<CertInfoEntity> {
bean.certProvider = certReader.detail.issuer.commonName;
bean.userId = userId;
bean.projectId = req.projectId;
if (req.file) {
bean.certFile = req.file;
}
await this.addOrUpdate(bean);
return bean;
}
packages/ui/certd-server/src/plugins/plugin-cert/plugin/cert-plugin/base-convert.ts
-1
View File
@@ -84,7 +84,6 @@ export abstract class CertApplyBaseConvertPlugin extends AbstractTaskPlugin {
const emitter = this.ctx.emitter;
const value = {
cert: this.cert,
file: this._result.files[0].path,
};
await emitter.emit(EVENT_CERT_APPLY_SUCCESS, value);
}